Skip to content

fix(Guild): cache soundboard sounds when patching #10857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

N1ckPro
Copy link
Contributor

@N1ckPro N1ckPro commented Apr 26, 2025

Please describe the changes this PR makes and why it should be merged:
Guild's soundboard sounds are sent with the guild create event but are never cached before fetching them.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@N1ckPro N1ckPro requested a review from a team as a code owner April 26, 2025 17:41
@N1ckPro N1ckPro requested review from vladfrangu, iCrawl, kyranet and SpaceEEC and removed request for a team April 26, 2025 17:41
Copy link

vercel bot commented Apr 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2025 5:42pm

@Jiralite Jiralite added this to the discord.js 14.19 milestone Apr 26, 2025
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Apr 26, 2025
@Jiralite Jiralite merged commit e827644 into discordjs:v14 Apr 26, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants